Skip to content

Conversation

@strongtz
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 11, 2026 02:34
@tencent-adm
Copy link
Member

tencent-adm commented Jan 11, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for the Qualcomm ARM64 Vulkan driver on Windows platforms by including qcvkarm64xum.dll in the list of well-known driver paths that the simplevk loader attempts when other loading methods fail.

Changes:

  • Extended the 64-bit preprocessor conditional to include ARM64 architectures (__aarch64__ and _M_ARM64)
  • Added qcvkarm64xum.dll to the list of 64-bit Windows drivers
  • Updated documentation to reflect the new Qualcomm ARM64 driver in the fallback driver list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/simplevk.cpp Adds ARM64 architecture checks to the 64-bit conditional and includes qcvkarm64xum.dll in the well-known driver paths
docs/developer-guide/vulkan-driver-loader.md Documents the new Qualcomm ARM64 driver in the list of 64-bit fallback drivers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.08%. Comparing base (cf7ed87) to head (0840cf3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6502      +/-   ##
==========================================
- Coverage   93.08%   93.08%   -0.01%     
==========================================
  Files         807      807              
  Lines      256419   255841     -578     
==========================================
- Hits       238687   238144     -543     
+ Misses      17732    17697      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nihui nihui merged commit 41187d4 into Tencent:master Jan 11, 2026
114 of 116 checks passed
@nihui
Copy link
Member

nihui commented Jan 11, 2026

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants