-
Notifications
You must be signed in to change notification settings - Fork 4.4k
simplevk: add qcvkarm64xum.dll from qualcomm windows driver #6502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for the Qualcomm ARM64 Vulkan driver on Windows platforms by including qcvkarm64xum.dll in the list of well-known driver paths that the simplevk loader attempts when other loading methods fail.
Changes:
- Extended the 64-bit preprocessor conditional to include ARM64 architectures (
__aarch64__and_M_ARM64) - Added
qcvkarm64xum.dllto the list of 64-bit Windows drivers - Updated documentation to reflect the new Qualcomm ARM64 driver in the fallback driver list
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/simplevk.cpp | Adds ARM64 architecture checks to the 64-bit conditional and includes qcvkarm64xum.dll in the well-known driver paths |
| docs/developer-guide/vulkan-driver-loader.md | Documents the new Qualcomm ARM64 driver in the list of 64-bit fallback drivers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f90bfb7 to
0840cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6502 +/- ##
==========================================
- Coverage 93.08% 93.08% -0.01%
==========================================
Files 807 807
Lines 256419 255841 -578
==========================================
- Hits 238687 238144 -543
+ Misses 17732 17697 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your contribution ! |
No description provided.